Skip to content

Commit

Permalink
fix(app): Verify existence of review app before resizing process (#77)
Browse files Browse the repository at this point in the history
  • Loading branch information
CuriousLearner authored Oct 9, 2024
1 parent 6ebbdea commit 2b2da0d
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 1 deletion.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased] - 2024-10-XX

### Fixed

* Verify existence of review app before resizing process with `ps resize`.

## [4.6.2] - 2024-09-03

### Fixed
Expand Down
2 changes: 1 addition & 1 deletion app/app.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ import (
"fmt"
"os"
"os/signal"
"syscall"
"strconv"
"strings"
"syscall"
"time"

"github.com/apppackio/apppack/auth"
Expand Down
4 changes: 4 additions & 0 deletions cmd/ps.go
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,10 @@ var psResizeCmd = &cobra.Command{
a, err := app.Init(AppName, UseAWSCredentials, SessionDurationSeconds)
checkErr(err)
a.LoadDeployStatus()
if a.IsReviewApp() {
_, err = a.ReviewAppExists()
checkErr(err)
}
_, err = a.DeployStatus.FindProcess(processType)
if err != nil {
printWarning(fmt.Sprintf("Service %q does not exist. Settings will be used if the service is created later.\n", processType))
Expand Down

0 comments on commit 2b2da0d

Please sign in to comment.