Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix volume transformation, add observation wrapper #7

Merged
merged 38 commits into from
Jul 19, 2024
Merged

Fix volume transformation, add observation wrapper #7

merged 38 commits into from
Jul 19, 2024

Conversation

carlocagnetta
Copy link
Collaborator

@carlocagnetta carlocagnetta commented Jun 28, 2024 •
edited
Loading

  • Fix observations to MultiBoxSpace:
    All observations_spaces are now MultiBox
  • Fix volume transformation:
    Was buggy when transformations were laying the volume origin in negative absolute coordinates,
    Solution: project the origin into positive octant
  • Fix clustering:
    Buggy behavior when no noise cluster was present. Fixed that as well as parameters.
  • New volumes src
    New src folder for volumes' operations
  • AddRewardDetailsWrapper:
    Wrapper to keep memory of the best reward and action seen so far.
    Best reward and action are stacked at the end of every observation.
  • Add tests for optimal slice
  • Add more volumes
  • Normalizing volumes to same spacing
  • Add class for ImageVolume and TransformedVolume

MischaPanch
MischaPanch requested changes Jun 30, 2024
View reviewed changes
scripts/random_volume_transformations.ipynb Outdated Show resolved Hide resolved
src/armscan_env/envs/labelmaps_navigation.py Outdated Show resolved Hide resolved
src/armscan_env/envs/labelmaps_navigation.py Outdated Show resolved Hide resolved
src/armscan_env/envs/labelmaps_navigation.py Outdated Show resolved Hide resolved
src/armscan_env/envs/state_action.py Outdated Show resolved Hide resolved
src/armscan_env/wrapper.py Outdated Show resolved Hide resolved
src/armscan_env/wrapper.py Outdated Show resolved Hide resolved
src/armscan_env/wrapper.py Show resolved Hide resolved
src/armscan_env/wrapper.py Show resolved Hide resolved
test/armscan_env/test_labelmap_volumes.py Show resolved Hide resolved
@MischaPanch
Copy link
Collaborator

Pls also fix the failing pipeline - why do the linting tests not start?

@carlocagnetta carlocagnetta linked an issue Jul 4, 2024 that may be closed by this pull request
Relative volume direction (orientation) considered in slicing actions #9
Closed
This was referenced Jul 12, 2024
Closed
Closed
Closed
@carlocagnetta carlocagnetta merged commit 991a9b4 into main Jul 19, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MischaPanch MischaPanch MischaPanch requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Relative volume direction (orientation) considered in slicing actions Volumes interpolation
2 participants
@carlocagnetta @MischaPanch