New Render Settings, UI controls, parameters exposed #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
luisbarrancos
commented
Mar 3, 2019
•
luisbarrancos
commented
- Added NEtemplates for asBlendNormals, asRaySwitchSurface, asSurfaceLuminance, asBlendNormals, asASCCDL, asMatte (new shaders added in Add new shaders, Maya matte support, fixes appleseed#2426) and icons for the same nodes (Update icons and documentation to include the color inversion and color decision list shader #185)
- Added and expose cast indirect controls for delta lights, and reorganize the delta lights appleseed UI sections
- Reorganize the UI for mesh/geometry attributes, sections for SPPM, and medium priority, and expose bias control.
- Remove duplicate turbitidy scale from physical sky and clean its UI
- Add completely new render globals (or render settings), split into the default Maya section, appleseed and now lighting, output and system. Toggle the controls and sections, subsections according to values of parent attributes, and added Maya annotation and status bar messages
- Added render stamp status bar message referencing the string replacement allowed by default
- Fix attribute spreadsheet hiding the appleseed keyable attributes (Shading node attributes not showing in Maya's attribute spreadsheet #167)
- Minor c++ fixes (missing MString header, fixing wrong order in constructor initializer list, and replacing 0 by nullptr where appropriate)
- Set softmin and softmax in some attributes according to appleseed defaults
dictoon
requested changes
Mar 3, 2019
|
Thanks! Some commit titles deserves to be more descriptive, for instance actually includes a whole new Render Globals UI. |
i think i squashed the wrong commit when compacting the commit history but that will be fixed |
|
This PR will need to be rebased and related commits to be squashed together. |
|
Please let us know when it's ready for another round of review! |
I think this stage is ready but i would like to add the new attribute spreadsheet section and some other features (WIP). Screenshots sent by mail (too many for the PR) |
luisbarrancos
force-pushed
the
ui_rework
branch
from
fa0e0aa
to
d1431d8
Compare
luisbarrancos
force-pushed
the
ui_rework
branch
2 times, most recently
from
5b31a48
to
3de2fc3
Compare
namely asASCCDL, asBlendNormals, asRaySwitchSurface, asSurfaceLuminance. Split the render globals in Lighting, Output, System tabs and exposed some controls to Dirac delta lights. Minor fixes and cleanups.
luisbarrancos
force-pushed
the
ui_rework
branch
from
3de2fc3
to
a47b779
Compare
dictoon
approved these changes
Mar 10, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.