Add system and libraries information to render log #328

Mango-3 · 2019-10-11T16:46:53Z

Adds detailed information in the render log about the system as well as the appleseed and 3rd. party libraries linked with the plugin (feature request Print version, library and system information on startup #313).

The screenshot below shows a test output of the render log with the added information:

dictoon

Awesome, thanks!

This is a good first step as it addresses the issue. In a second step (and separate PR), it would be nice to expose and reuse the code from appleseed.shared to avoid code duplication and, inevitably, code getting out of sync.

dictoon · 2019-10-14T11:02:16Z

src/appleseed-max-impl/appleseedrenderer/appleseedrenderer.cpp

+        print_third_party_libraries_information();
+        asf::System::print_information(asr::global_logger());
+    }
+


Keep a single blank line.

dictoon · 2019-10-14T11:03:27Z

src/appleseed-max-impl/utilities.h

@@ -74,7 +74,6 @@ class Texmap;

 void update_map_buttons(IParamMap2* param_map);

-


Revert, we use two blank lines before block comments.

dictoon · 2019-10-14T11:04:04Z

src/appleseed-max-impl/utilities.h

+// Version information functions.
+//
+
+extern void print_libraries_information();


The extern qualifiers are redundant, you can remove them.

dictoon · 2019-10-14T11:04:42Z

src/appleseed-max-impl/utilities.h

@@ -129,6 +128,17 @@ std::string insert_procedural_texture_and_instance(
    renderer::ParamArray        texture_params = renderer::ParamArray(),
    renderer::ParamArray        texture_instance_params = renderer::ParamArray());



Add additional blank line.

dictoon · 2019-10-14T11:04:48Z

src/appleseed-max-impl/utilities.h

+
+extern const char* to_enabled_disabled(const bool value);
+
+extern void print_third_party_libraries_information();



Add additional blank line.

dictoon · 2019-10-14T11:05:06Z

src/appleseed-max-impl/utilities.cpp

+void print_libraries_features()
+{
+        const bool WithDisneyMaterial =
+    #ifdef APPLESEED_WITH_DISNEY_MATERIAL


Left-align preprocessor statements.

dictoon · 2019-10-14T11:05:57Z

src/appleseed-max-impl/utilities.cpp

+    return value ? "enabled" : "disabled";
+}
+
+void print_libraries_information()


print_appleseed_library_information() would be clearer.

dictoon · 2019-10-14T11:06:10Z

src/appleseed-max-impl/utilities.cpp

+        asf::Compiler::get_compiler_version());
+}
+
+void print_libraries_features()


Similarly, print_appleseed_library_features() here.

dictoon · 2019-10-14T11:08:05Z

src/appleseed-max-impl/utilities.cpp

+        const asf::APIStringPair& version = versions[i];
+        const char* lib_name = version.m_first.c_str();
+        const char* lib_version = version.m_second.c_str();
+        const size_t lib_name_length = strlen(lib_name);


std::strlen()

(And yes, the std:: qualifier is missing on appleseed's side.)

Mango-3 · 2019-10-14T16:22:50Z

Addressed your comments. True code exposed from appleseed.shared would be available to all plugins and is the better option long-term. This can be refactored at a later point.

dictoon · 2019-10-15T07:11:11Z

Follow-up tickets:

appleseed: Expose the code that prints appleseed library and 3rd parties information appleseed#2722
appleseed-max: Use appleseed's code to print library information #329

Add system and libaries information to render log

12ba9fa

Mango-3 changed the title ~~Add system and libaries information to render log~~ Add system and libraries information to render log Oct 11, 2019

Code cleanup

baf8f51

dictoon requested changes Oct 14, 2019

View reviewed changes

Address review comments

88a2a91

dictoon approved these changes Oct 15, 2019

View reviewed changes

dictoon merged commit d326e83 into appleseedhq:master Oct 15, 2019

Mango-3 deleted the renderlog branch October 17, 2019 08:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add system and libraries information to render log #328

Add system and libraries information to render log #328

Mango-3 commented Oct 11, 2019

dictoon left a comment

dictoon Oct 14, 2019

dictoon Oct 14, 2019

dictoon Oct 14, 2019

dictoon Oct 14, 2019

dictoon Oct 14, 2019

dictoon Oct 14, 2019

dictoon Oct 14, 2019

dictoon Oct 14, 2019

dictoon Oct 14, 2019

Mango-3 commented Oct 14, 2019

dictoon commented Oct 15, 2019

		@@ -74,7 +74,6 @@ class Texmap;

		void update_map_buttons(IParamMap2* param_map);

		@@ -129,6 +128,17 @@ std::string insert_procedural_texture_and_instance(
		renderer::ParamArray texture_params = renderer::ParamArray(),
		renderer::ParamArray texture_instance_params = renderer::ParamArray());


		extern const char* to_enabled_disabled(const bool value);

		extern void print_third_party_libraries_information();

Add system and libraries information to render log #328

Add system and libraries information to render log #328

Conversation

Mango-3 commented Oct 11, 2019

dictoon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Mango-3 commented Oct 14, 2019

dictoon commented Oct 15, 2019