Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve consistency and add Redis username configuration #827

Merged
merged 2 commits into from
Jan 4, 2025

Conversation

appleboy
Copy link
Owner

@appleboy appleboy commented Jan 4, 2025

  • Add username field to Redis configuration in multiple files
  • Simplify JSON formatting for gc_pause array
  • Standardize table formatting in README.md
  • Update JavaScript example to use double quotes instead of single quotes for consistency
  • Fix missing semicolon in JavaScript example
  • Add tests for the new username field in Redis configuration

- Add `username` field to Redis configuration in multiple files
- Simplify JSON formatting for `gc_pause` array
- Standardize table formatting in README.md
- Update JavaScript example to use double quotes instead of single quotes for consistency
- Fix missing semicolon in JavaScript example
- Add tests for the new `username` field in Redis configuration

Signed-off-by: appleboy <[email protected]>
- Add assertion to check that `Redis.Username` is an empty string in the `TestValidateConf` test function

Signed-off-by: appleboy <[email protected]>
@appleboy appleboy merged commit e34e2c4 into master Jan 4, 2025
10 checks passed
@appleboy appleboy deleted the redis branch January 4, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant