refactor(storage): Redis configuration handling and initialization #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update `go-redis` dependency from v9.5.1 to v9.5.3 - Modify `InitAppStatus` to pass individual Redis configuration parameters instead of the entire config object - Refactor `New` function in `redis.go` to accept individual parameters for Redis configuration - Remove `config` dependency from `redis.go` - Add new fields to `Storage` struct for Redis configuration parameters - Update `Init` method in `Storage` to use new Redis configuration fields - Refactor tests in `redis_test.go` to use new `New` function signature - Add assertions in `TestRedisEngine` to verify key reset and value retrieval Signed-off-by: appleboy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go-redisdependency from v9.5.1 to v9.5.3InitAppStatusto pass individual Redis configuration parameters instead of the entire config objectNewfunction inredis.goto accept individual parameters for Redis configurationconfigdependency fromredis.goStoragestruct for Redis configuration parametersInitmethod inStorageto use new Redis configuration fieldsredis_test.goto use newNewfunction signatureTestRedisEngineto verify key reset and value retrieval