Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overflow-safe integer midpoint with rounding control
Draft because I am not sold on the free-function spelling
midpoint(a, b)
. It is desirable by symmetry withmin(a, b)
andmax(a, b)
, and because it correctly captures that this is a commutative operation; neither operand is privileged. But Swift generally eschews free functions. This could equally be a static member (Int.midpoint(a, b)
), or possibly use some other spelling.Declaration:
Usage:
Unlike commonly seen expressions such as
(a+b)/2
or(a+b) >> 1
ora + (b-a)/2
(all of which may overflow for fixed-width integers), this function never overflows, and the result is guaranteed to be representable in the result type.The default rounding rule is
.down
, which matches the behavior of(a + b) >> 1
when that expression does not overflow. Rounding.towardZero
matches the behavior of(a + b)/2
when that expression does not overflow. All other rounding modes are supported.