Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read the #242 Using tests from “Violet - Python VM written in Swift” before.
🐰 Discussion
Currently
Codable
usesdescription
which is aString
with radix 10.Following options may be better:
UInt32
with signWe need to remember that
BigInt
can get really big. In [BigInt tests] 💀 Init from float 754 we operate on integers that have 3000 digits with 32 radix. With radix 10 they would be much longer.