feat: add AppiumBy instead of MobileBy #659
Conversation
| from selenium.webdriver.common.by import By | ||
|
|
||
|
|
||
| class AppiumBy(By): |
There was a problem hiding this comment.
I'd prefer it to not be a breaking change. E.g. keep the MobileBy strategy, but simply mark it as deprecated
AppiumBy may then be inherited from MobileBy to avoid unnecessary duplication.
There was a problem hiding this comment.
MobileBy.ID in appium/webdriver/common/mobileby.py (inherits AppiumBy) etc are str. AppiumBy.ID also str. So basically both ID are set as id to find_element, for example.
I think they do not have breaking change... something wrong?
Yea, I was finding the way to print deprecation message when MobileBy.ID was called or when MobileBy.ID was given in find_element. But it was simply str.
So currently I've put the deprecation message in the module description.
There was a problem hiding this comment.
Maybe we could use https://www.py4u.net/discuss/182959 (https://pypi.org/project/deprecation/#description) to mark things as deprecated
There was a problem hiding this comment.
There was a problem hiding this comment.
mm, the deprecation package also does not work for str of class variables?
Yea, I think only documentation can mention it.
|
mm, it looks like current building docs partially depend on the published python client module. |
part of #645