Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert the clearCache change for API 33+ #597

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

mykola-mokhnach
Copy link
Contributor

@mykola-mokhnach mykola-mokhnach commented Jan 10, 2024

Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this if this works over Android 13, but one thing in appium/appium#19638 occurred in Android 12, which was UiAutomatorBridge.getInstance().getUiAutomation().setServiceInfo(null);. So maybe this won't help for Android 12

I can test this later with Android 13 (not soon but by tonight)

@KazuCocoa
Copy link
Member

Btw, my previous find an element and click/send keys to the element a couple of times did not cause the issue, so possibly @eglitise 's help would be needed to test with this.

@mykola-mokhnach
Copy link
Contributor Author

At least in the framework itself I observe no changes regarding the legacy API, which gives me more confidence.

@mykola-mokhnach mykola-mokhnach merged commit 719122f into appium:master Jan 10, 2024
8 of 12 checks passed
@mykola-mokhnach mykola-mokhnach deleted the cache branch January 10, 2024 19:35
github-actions bot pushed a commit that referenced this pull request Jan 10, 2024
## [6.0.3](v6.0.2...v6.0.3) (2024-01-10)

### Bug Fixes

* Revert the clearCache change for API 33+ ([#597](#597)) ([719122f](719122f))
Copy link

🎉 This PR is included in version 6.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants