Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Start page status monitoring on page change event as well #402

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

mykola-mokhnach
Copy link
Contributor

Case without target provisioning event that this PR tries to address:

{"level":"VERBOSE","message":"[1a70c491][XCUITestDriver@339b] Attempting to set url 'http://127.0.0.1:8100/health'","timestamp":"2024-08-07 12:24:25.231"}
{"level":"VERBOSE","message":"[1a70c491][RemoteDebugger] Navigating to new URL: 'http://127.0.0.1:8100/health'","timestamp":"2024-08-07 12:24:25.232"}
{"level":"VERBOSE","message":"[1a70c491][RemoteDebugger] Sending '_rpc_forwardSocketData:' message to app 'PID:530', page '1', target 'page-11' (id: 30): 'Page.navigate'","timestamp":"2024-08-07 12:24:25.232"}
{"level":"VERBOSE","message":"[1a70c491][RemoteDebugger] Received data response from send (id: 30): '{}'","timestamp":"2024-08-07 12:24:25.262"}
{"level":"VERBOSE","message":"[1a70c491][RemoteDebugger] Pages changed for PID:530: [{\"id\":1,\"title\":\"\",\"url\":\"about:blank\",\"isKey\":false}] -> [{\"id\":1,\"title\":\"\",\"url\":\"about:blank\",\"isKey\":true}]","timestamp":"2024-08-07 12:24:25.264"}
{"level":"VERBOSE","message":"[1a70c491][RemoteDebugger] Notified that an application has been updated","timestamp":"2024-08-07 12:24:25.264"}
{"level":"VERBOSE","message":"[1a70c491][RemoteDebugger] Sending to Web Inspector took 32ms","timestamp":"2024-08-07 12:24:25.264"}
{"level":"VERBOSE","message":"[1a70c491][RemoteDebugger] Pages changed for PID:530: [{\"id\":1,\"title\":\"\",\"url\":\"about:blank\",\"isKey\":true}] -> [{\"id\":1,\"title\":\"Health Check\",\"url\":\"http://127.0.0.1:8100/health\",\"isKey\":true}]","timestamp":"2024-08-07 12:24:25.398"}
{"level":"VERBOSE","message":"[1a70c491][RemoteDebugger] Notified that an application has been updated","timestamp":"2024-08-07 12:24:25.454"}
{"level":"VERBOSE","message":"[1a70c491][RemoteDebugger] Notified that an application has been updated","timestamp":"2024-08-07 12:24:25.456"}
{"level":"VERBOSE","message":"[1a70c491][RemoteDebugger] Notified that new application 'PID:540' has connected","timestamp":"2024-08-07 12:24:25.511"}
{"level":"VERBOSE","message":"[1a70c491][RemoteDebugger] Notified that an application has been updated","timestamp":"2024-08-07 12:24:25.626"}
{"level":"VERBOSE","message":"[1a70c491][RemoteDebugger] Notified that new application 'PID:542' has connected","timestamp":"2024-08-07 12:24:27.674"}
{"level":"VERBOSE","message":"[1a70c491][RemoteDebugger] Notified that an application has been updated","timestamp":"2024-08-07 12:24:27.950"}
{"level":"VERBOSE","message":"[1a70c491][RemoteDebugger] Timed out after 6000ms of waiting for the http://127.0.0.1:8100/health page readiness. Continuing anyway","timestamp":"2024-08-07 12:24:31.232"}

Case with provisioning event:

{"level":"VERBOSE","message":"[1a70c491][XCUITestDriver@339b] Attempting to set url 'https://www.example.io/referral'","timestamp":"2024-08-07 12:24:34.651"}
{"level":"VERBOSE","message":"[1a70c491][RemoteDebugger] Navigating to new URL: 'https://www.example.io/referral'","timestamp":"2024-08-07 12:24:34.651"}
{"level":"VERBOSE","message":"[1a70c491][RemoteDebugger] Sending '_rpc_forwardSocketData:' message to app 'PID:530', page '1', target 'page-11' (id: 34): 'Page.navigate'","timestamp":"2024-08-07 12:24:34.651"}
{"level":"VERBOSE","message":"[1a70c491][RemoteDebugger] Received data response from send (id: 34): '{}'","timestamp":"2024-08-07 12:24:34.664"}
{"level":"VERBOSE","message":"[1a70c491][RemoteDebugger] Sending to Web Inspector took 13ms","timestamp":"2024-08-07 12:24:34.664"}
{"level":"VERBOSE","message":"[1a70c491][RemoteDebugger] Provisional target created for app 'PID:530', 'page-25'. Ignoring until target update event","timestamp":"2024-08-07 12:24:34.689"}
{"level":"VERBOSE","message":"[1a70c491][RemoteDebugger] Notified that an application has been updated","timestamp":"2024-08-07 12:24:34.695"}
{"level":"VERBOSE","message":"[1a70c491][RemoteDebugger] Notified that an application has been updated","timestamp":"2024-08-07 12:24:34.697"}
{"level":"VERBOSE","message":"[1a70c491][RemoteDebugger] Target updated for app 'PID:530'. Old target: 'page-11', new target: 'page-25'","timestamp":"2024-08-07 12:24:35.042"}
{"level":"VERBOSE","message":"[1a70c491][RemoteDebugger] Target destroyed for app 'PID:530': page-11","timestamp":"2024-08-07 12:24:35.045"}
{"level":"VERBOSE","message":"[1a70c491][RemoteDebugger] Found provisional target for app 'PID:530'. Old target: 'page-11', new target: 'page-25'. Updating","timestamp":"2024-08-07 12:24:35.045"}
{"level":"VERBOSE","message":"[1a70c491][RemoteDebugger] Sending '_rpc_forwardSocketData:' message to app 'PID:530', page '1', target 'page-25' (id: 36): 'Page.enable'","timestamp":"2024-08-07 12:24:35.045"}
{"level":"VERBOSE","message":"[1a70c491][RemoteDebugger] Received data response from send (id: 36): '{}'","timestamp":"2024-08-07 12:24:35.073"}
{"level":"VERBOSE","message":"[1a70c491][RemoteDebugger] Sending javascript command: 'document.readyState;'","timestamp":"2024-08-07 12:24:35.073"}
{"level":"VERBOSE","message":"[1a70c491][RemoteDebugger] Sending '_rpc_forwardSocketData:' message to app 'PID:530', page '1', target 'page-25' (id: 38): 'Runtime.evaluate'","timestamp":"2024-08-07 12:24:35.073"}
{"level":"VERBOSE","message":"[1a70c491][RemoteDebugger] Notified that an application has been updated","timestamp":"2024-08-07 12:24:35.074"}
{"level":"VERBOSE","message":"[1a70c491][RemoteDebugger] Received data response from send (id: 38): '\"loading\"'","timestamp":"2024-08-07 12:24:35.117"}
{"level":"VERBOSE","message":"[1a70c491][RemoteDebugger] Sending to Web Inspector took 43ms","timestamp":"2024-08-07 12:24:35.117"}
{"level":"VERBOSE","message":"[1a70c491][RemoteDebugger] Document readyState is 'loading'. The pageLoadStrategy is 'normal'","timestamp":"2024-08-07 12:24:35.117"}
{"level":"VERBOSE","message":"[1a70c491][RemoteDebugger] Notified that an application has been updated","timestamp":"2024-08-07 12:24:35.143"}
{"level":"VERBOSE","message":"[1a70c491][RemoteDebugger] Pages changed for PID:530: [{\"id\":1,\"title\":\"Health Check\",\"url\":\"http://127.0.0.1:8100/health\",\"isKey\":true}] -> [{\"id\":1,\"title\":\"Referral\",\"url\":\"https://www.example.io/referral\",\"isKey\":true}]","timestamp":"2024-08-07 12:24:35.243"}
{"level":"VERBOSE","message":"[1a70c491][RemoteDebugger] Received page change notice for app 'PID:530' but the listing has not changed. Ignoring.","timestamp":"2024-08-07 12:24:35.583"}
{"level":"VERBOSE","message":"[1a70c491][RemoteDebugger] The page https://www.example.io/referral is ready in 938ms","timestamp":"2024-08-07 12:24:35.590"}
{"level":"VERBOSE","message":"[1a70c491][RemoteDebugger] Sending '_rpc_forwardSocketData:' message to app 'PID:530', page '1', target 'page-25' (id: 40): 'Console.enable'","timestamp":"2024-08-07 12:24:35.590"}
{"level":"VERBOSE","message":"[1a70c491][RemoteDebugger] Received data response from send (id: 40): '{}'","timestamp":"2024-08-07 12:24:35.649"}
{"level":"VERBOSE","message":"[1a70c491][RemoteDebugger] Sending to Web Inspector took 59ms","timestamp":"2024-08-07 12:24:35.649"}
{"level":"VERBOSE","message":"[1a70c491][XCUITestDriver@339b] Responding to client with driver.setUrl() result: null","timestamp":"2024-08-07 12:24:35.649"}

@mykola-mokhnach mykola-mokhnach requested a review from jlipps August 7, 2024 21:08
@mykola-mokhnach mykola-mokhnach merged commit 8f71d19 into appium:master Aug 8, 2024
7 checks passed
@mykola-mokhnach mykola-mokhnach deleted the wait branch August 8, 2024 07:44
github-actions bot pushed a commit that referenced this pull request Aug 8, 2024
## [12.0.2](v12.0.1...v12.0.2) (2024-08-08)

### Bug Fixes

* Start page status monitoring on page change event as well ([#402](#402)) ([8f71d19](8f71d19))
Copy link

github-actions bot commented Aug 8, 2024

🎉 This issue has been resolved in version 12.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants