Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update atoms to selenium 4.19.0 basis #375

Merged
merged 5 commits into from
Apr 16, 2024
Merged

feat: update atoms to selenium 4.19.0 basis #375

merged 5 commits into from
Apr 16, 2024

Conversation

KazuCocoa
Copy link
Member

@KazuCocoa KazuCocoa commented Apr 16, 2024 •
edited
Loading

@KazuCocoa KazuCocoa changed the title feat: update atoms to selenium 4.19.0 basis and keeps React input operation feat: update atoms to selenium 4.15.0 basis and keeps React input operation Apr 16, 2024
@KazuCocoa KazuCocoa changed the title feat: update atoms to selenium 4.15.0 basis and keeps React input operation feat: update atoms to selenium 4.19.0 basis Apr 16, 2024
@KazuCocoa KazuCocoa marked this pull request as ready for review April 16, 2024 08:35
mykola-mokhnach
mykola-mokhnach approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@mykola-mokhnach mykola-mokhnach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you would want to release this PR together with #376

@mykola-mokhnach
Copy link
Contributor

mykola-mokhnach commented Apr 16, 2024 •
edited
Loading

It would be nice if we could add an e2e test for the react input case for the future

@KazuCocoa
Copy link
Member Author

Sounds good. Let me check Jlipps's thoughts as well in #376
If the react workaround in Appium makes sense, will merge the PR to this branch, and then will merge this to master to publish a new one.
(Agree with the test, bsaically)

@KazuCocoa
Copy link
Member Author

I'm going to merge this only since I have closed #376 and moving to appium/appium#20004 (comment) idea for this case. I think it is better than adding atoms's customization only in Appium Atoms.

@KazuCocoa KazuCocoa merged commit cc5a084 into master Apr 16, 2024
11 checks passed
@KazuCocoa KazuCocoa deleted the atoms-update branch April 16, 2024 23:54
github-actions bot pushed a commit that referenced this pull request Apr 16, 2024
@semantic-release-bot
chore(release): 11.1.0 [skip ci]
73827bf 
## [11.1.0](v11.0.9...v11.1.0) (2024-04-16)

### Features

* update atoms to selenium 4.19.0 basis ([#375](#375)) ([cc5a084](cc5a084))
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 11.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

jlipps
jlipps reviewed Apr 18, 2024
View reviewed changes
Copy link
Member

@jlipps jlipps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure this will bring back a bug that I fixed in the atoms, but which the Selenium people did not like and reverted since it caused some other issues. Are all the tests passing with these changes?

@KazuCocoa
Copy link
Member Author

Oh, do you mean SeleniumHQ/selenium#12704 ...? Actually it reverted SeleniumHQ/selenium#12557 .

Hm, shall we apply SeleniumHQ/selenium#12557 to our appium atoms? @jlipps

yea, CI here and https://github.com/appium/appium-xcuitest-driver were fine with this.

@KazuCocoa
Copy link
Member Author

KazuCocoa commented Apr 19, 2024 •
edited
Loading

ah, maybe typeof window .... related errors? Then yea, I removed them to remove diffs after creating atoms on this pr. So actually your fix was applied to this atoms.

Maybe we should note it in this atoms note. -> https://github.com/appium/appium-remote-debugger/blob/master/atoms-notes.md Updated

@jlipps
Copy link
Member

jlipps commented Apr 19, 2024

yep exactly. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlipps jlipps jlipps left review comments

@mykola-mokhnach mykola-mokhnach mykola-mokhnach approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KazuCocoa @mykola-mokhnach @jlipps