Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: appropriately translate com.apple.SpringBoard and some system prompts #384

Merged
merged 1 commit into from
Sep 23, 2023

Conversation

mwakizaka
Copy link
Contributor

@mykola-mokhnach
Copy link
Contributor

Thanks @mwakizaka
Could you also please check why unit tests fail before we merge?

@mwakizaka
Copy link
Contributor Author

Thanks @mwakizaka Could you also please check why unit tests fail before we merge?

As far as I checked it's most likely because of appium/node-simctl@c691f20.
Since appium/node-simctl@c691f20, Simctl.prototype likely has an empty dictionary.

% node
Welcome to Node.js v18.15.0.
Type ".help" for more information.
> const nodeSimctl = require('node-simctl')
undefined
> nodeSimctl.Simctl.prototype
{}

Do you have any idea how to resolve it?

@mykola-mokhnach
Copy link
Contributor

Linking #386

@mykola-mokhnach
Copy link
Contributor

@mwakizaka I have fixed the tests. Please rebase

@mwakizaka
Copy link
Contributor Author

Thank you! Done

@KazuCocoa KazuCocoa merged commit edde636 into appium:master Sep 23, 2023
7 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 23, 2023
## [5.3.2](v5.3.1...v5.3.2) (2023-09-23)

### Bug Fixes

* appropriately translate com.apple.SpringBoard and system prompts ([#384](#384)) ([edde636](edde636))
@github-actions
Copy link

🎉 This PR is included in version 5.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants