feat: changed "element" property, added complete information about element #808
Conversation
|
@mykola-mokhnach Review please |
…ot receiving method
|
@mykola-mokhnach Done 👌 |
|
Could you sign the CLA? |
Done |
|
@mykola-mokhnach @KazuCocoa Could you please tell me why some tests fail? |
| @@ -369,12 +369,16 @@ - (BOOL)fb_dismissKeyboardWithKeyNames:(nullable NSArray<NSString *> *)keyNames | |||
| if (nil != auditTypeValue) { | |||
| auditType = valuesToNamesMap[auditTypeValue] ?: [auditTypeValue stringValue]; | |||
| } | |||
| id<FBXCElementSnapshot> snapshot = [extractIssueProperty(issue, @"element") fb_takeSnapshot]; | |||
| NSDictionary *elementObject = snapshot ? [self.class dictionaryForElement:snapshot recursive:NO] : @{}; | |||
There was a problem hiding this comment.
is that really what is needed? Just to get all attributes of an element?
I though element path in the tree is necessary
There was a problem hiding this comment.
The idea behind my proposal is to provide all the attributes of the element for which the problem was found, so that it would be similar to the native AccessibilityAudit API.
This will be enough for writing automated tests and debugging and much more.
In case I’m missing something could you point me to example of getting element path in appium
There was a problem hiding this comment.
it is ok, just wanted to confirm it is exactly what is needed. Then I assume elementAttributes would be a proper name
several random tests may fail in CI because of its slowness. This is known |
mykola-mokhnach
changed the title
|
Please also don't forget to update the extension documentation at https://github.com/appium/appium-xcuitest-driver/blob/master/docs/execute-methods.md after the change is published |
## [5.15.0](v5.14.0...v5.15.0) (2023-11-16) ### Features * Add element attributes to the performAccessibilityAudit output ([#808](#808)) ([0d7e4a6](0d7e4a6))
Yes, I will update the version of the WDA dependency in appium-xcui-driver and the documentation. |
Implementation of this proposal: appium/appium#19354