fix: Provide signing arguments as command line parameters #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KazuCocoa
approved these changes
Sep 22, 2023
|
@KazuCocoa Could you please verify the patch with real devices before I merge it? |
KazuCocoa
reviewed
Sep 22, 2023
|
yes, sure. The arguments themselves seem good, but let me run on my local |
KazuCocoa
reviewed
Sep 22, 2023
KazuCocoa
approved these changes
Sep 22, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Sep 22, 2023
## [5.9.1](v5.9.0...v5.9.1) (2023-09-22) ### Bug Fixes * Provide signing arguments as command line parameters ([#779](#779)) ([51ba527](51ba527))
|
🎉 This PR is included in version 5.9.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to appium/appium#19190