chore: tweak device

appium · Sep 21, 2023 · e41ab83 · e41ab83
1 parent 3ec9628
commit e41ab83
Showing 1 changed file with 17 additions and 2 deletions.
diff --git a/WebDriverAgentLib/Commands/FBSessionCommands.m b/WebDriverAgentLib/Commands/FBSessionCommands.m
@@ -257,7 +257,8 @@ + (NSArray *)routes
 #endif
           @"ip" : [XCUIDevice sharedDevice].fb_wifiIPAddress ?: [NSNull null]
         },
-      @"build" : buildInfo.copy
+      @"build" : buildInfo.copy,
+      @"device": [self.class deviceName:[UIDevice currentDevice].userInterfaceIdiom]
     }
   );
 }
@@ -418,12 +419,26 @@ + (NSDictionary *)sessionInformation
   };
 }
 
++ (NSString *)deviceName:(UIUserInterfaceIdiom) currentDevice
+{
+  if (currentDevice == UIUserInterfaceIdiomPad) {
+    return @"iPad";
+  } else if (currentDevice == UIUserInterfaceIdiomTV) {
+    return @"Apple TV";
+  } else if (currentDevice == UIUserInterfaceIdiomPhone) {
+    return @"iPhone";
+  }
+  // CarPlay, Mac, Vision UI or unknown are possible
+  return @"Unknown";
+
+}
+
 + (NSDictionary *)currentCapabilities
 {
   FBApplication *application = [FBSession activeSession].activeApplication;
   return
   @{
-    @"device": ([UIDevice currentDevice].userInterfaceIdiom == UIUserInterfaceIdiomPad) ? @"ipad" : @"iphone",
+    @"device": [self.class deviceName:[UIDevice currentDevice].userInterfaceIdiom],
     @"sdkVersion": [[UIDevice currentDevice] systemVersion],
     @"browserName": application.label ?: [NSNull null],
     @"CFBundleIdentifier": application.bundleID ?: [NSNull null],