Delayed Startup check Strategy Added for common use #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumeet-kg
changed the title
|
LGTM |
santanusinha
requested changes
Dec 13, 2022
| log.error("Unable to pause thread", e); | ||
| } | ||
|
|
||
| return super.checkStartupState(dockerClient, containerId); |
There was a problem hiding this comment.
This seems to be wrong way to do this. Ideally the check should be done in a retry loop with timeout and backoff for some time, instead of just dead wait for some time and checking once? this will just make tests slow even for cases where the container actually starts up fast enough and severely limits the use cases for this
| @@ -27,7 +28,8 @@ public RabbitMQContainer(final RabbitMQContainerConfiguration rabbitMQContainerC | |||
| .withExposedPorts(rabbitMQContainerConfiguration.getPort(), rabbitMQContainerConfiguration.getManagementPort()) | |||
| .withLogConsumer(ContainerUtils.containerLogsConsumer(log)) | |||
| .waitingFor(new RabbitMQStatusCheck(rabbitMQContainerConfiguration)) | |||
| .withStartupTimeout(rabbitMQContainerConfiguration.getTimeoutDuration()); | |||
| .withStartupTimeout(rabbitMQContainerConfiguration.getTimeoutDuration()) | |||
| .withStartupCheckStrategy(new IsRunningStartupCheckStrategyWithDelay()); | |||
There was a problem hiding this comment.
This basically fixes a startup delay of 1 second blindly. Make this configurable as a constructor actually exists for doing this. getTimeoutDuration should ideally be deprecated or ignored if this is used or use the timeout to configure the retrier (see above comment) in the strategy..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the test container startup checks fails due to container not up or busy in acquiring IO resources.
This delay startup check strategy is used to check the state after a
{delayInMilliSec}ms delay.