Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fully complete I hope #3

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fully complete I hope #3

wants to merge 4 commits into from

Conversation

armstrca
Copy link
Collaborator

No description provided.

Samuel-Lubliner
Samuel-Lubliner reviewed Oct 31, 2023
View reviewed changes
Copy link

@Samuel-Lubliner Samuel-Lubliner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cant add post. Might want to try calling authorize in PhotosController and updating PhotoPolicy.

johnLeavell
johnLeavell reviewed Oct 31, 2023
View reviewed changes
Copy link

@johnLeavell johnLeavell left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to add a photo.

something to note: In production commented code is okay but before pushing to production you want to remove any uncommented / unused code.

app/controllers/photos_controller.rb
def photo_params
params.require(:photo).permit(:image, :comments_count, :likes_count, :caption, :owner_id)
end

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

having comments in development but when pushing to production you want to remove any unused / commented code

@Dantexkilljoy
Copy link

This is cool but its going to app dev. Other than that, you chillin ~with-rizz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Samuel-Lubliner Samuel-Lubliner Samuel-Lubliner left review comments

@johnLeavell johnLeavell johnLeavell left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@armstrca @Dantexkilljoy @johnLeavell @Samuel-Lubliner