fix(federation): fixed Selection::conditions
to merge field's subselection's conditions when necessary
#6323
+110
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
Selection::conditions
method, which is the Rust port of JS functionconditionsOfSelection
, has following comment:The comment suggested that the JS code was buggy and it was fixed in Rust port. But, it turned out that there are cases where the
Selection::Field(...)
case should merge with its subselection-set's conditions.Example:
In the example above, the
test
selection's condition may become aBoolean(false)
, influenced by its sub-selection-set.Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.