Skip to content

Commit

Permalink
docs: fix broken links (#2885)
Browse files Browse the repository at this point in the history
<!--
First, 🌠 thank you 🌠 for taking the time to consider a contribution to
Apollo!

Here are some important details to follow:

* ⏰ Your time is important
To save your precious time, if the contribution you are making will
take more than an hour, please make sure it has been discussed in an
        issue first. This is especially true for feature requests!

* 💡 Features
Feature requests can be created and discussed within a GitHub Issue.
Be sure to search for existing feature requests (and related issues!)
prior to opening a new request. If an existing issue covers the need,
please upvote that issue by using the 👍 emote, rather than opening a
        new issue.

* 🕷 Bug fixes
These can be created and discussed in this repository. When fixing a
bug,
please _try_ to add a test which verifies the fix. If you cannot, you
should
still submit the PR but we may still ask you (and help you!) to create a
test.

* Federation versions
Please make sure you're targeting the federation version you're opening
the PR for. Federation 2 (alpha) is currently located on the `main`
branch and prior versions of Federation live on the `version-0.x`
branch.

* 📖 Contribution guidelines
Follow
https://github.com/apollographql/federation/blob/HEAD/CONTRIBUTING.md
when submitting a pull request. Make sure existing tests still pass, and
add
        tests for all new behavior.

* ✏️ Explain your pull request
Describe the big picture of your changes here to communicate to what
        your pull request is meant to accomplish. Provide 🔗 links 🔗 to
        associated issues!

We hope you will find this to be a positive experience! Open source
contribution can be intimidating and we hope to alleviate that pain as
much
as possible. Without following these guidelines, you may be missing
context
that can help you succeed with your contribution, which is why we
encourage
discussion first. Ultimately, there is no guarantee that we will be able
to
merge your pull-request, but by following these guidelines we can try to
avoid disappointment.

-->
  • Loading branch information
shorgi authored Dec 8, 2023
1 parent 74ca7dd commit 4e630d9
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion docs/source/entities.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ type Product @key(fields: "id") {

Though not strictly required, it's best to use non-nullable fields for keys. If you use fields that return `null` values, GraphOS may encounter issues resolving the entity.

For more information on advanced key options, like how to define [multiple keys](./entities-advanced/#multiple-keys) or [compound keys](/entities-advanced/#compound-keys), see [Advanced topics for federation entities](./entities-advanced).
For more information on advanced key options, like how to define [multiple keys](./entities-advanced/#multiple-keys) or [compound keys](./entities-advanced/#compound-keys), see [Advanced topics for federation entities](./entities-advanced).

### 2. Define a reference resolver

Expand Down
2 changes: 1 addition & 1 deletion docs/source/managed-federation/deployment.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ As an example, follow these steps to deploy with a supergraph schema of a new re
}
```

This initiates a [launch](/graphos/delivery/launches/), as well as any downstream launches necessary for [contracts](graphos/delivery/contracts/#automatic-updates). It returns the launch IDs, with downstream launch IDs configured to return synchronously (`downstreamLaunchInitiation: "SYNC"`) with the mutation.
This initiates a [launch](/graphos/delivery/launches/), as well as any downstream launches necessary for [contracts](/graphos/delivery/contracts/#automatic-updates). It returns the launch IDs, with downstream launch IDs configured to return synchronously (`downstreamLaunchInitiation: "SYNC"`) with the mutation.

<Note>

Expand Down
2 changes: 1 addition & 1 deletion docs/source/metrics.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ If your library _does_ support federated tracing, see its documentation to learn
### In the Apollo Router

See [Sending Apollo Router usage data to GraphOS](/router/configuration/apollo-telemetry).
See [Sending Apollo Router usage data to GraphOS](/router/configuration/telemetry/apollo-telemetry).

### In `@apollo/gateway`

Expand Down

0 comments on commit 4e630d9

Please sign in to comment.