Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Install volta from lock file #364

Merged
merged 1 commit into from
Jun 26, 2023
Merged

ci: Install volta from lock file #364

merged 1 commit into from
Jun 26, 2023

Conversation

dbanty
Copy link
Contributor

@dbanty dbanty commented Jun 26, 2023

Volta install fails for arm Ubuntu because:

  1. Their rust-toolchain sets Rust to 1.63
  2. Hashbrown 0.14.0 is allowed by their Cargo.toml
  3. Hashbrown 0.14.0 MSRV is 1.64

I think just using the lock file should fix this

@dbanty
Copy link
Contributor Author

dbanty commented Jun 26, 2023

Also though, maybe the prebuilt binaries work again and we should try that?

@EverlastingBugstopper
Copy link
Contributor

they dont have prebuilt binaries for arm which is why we build from source for that target and no others

@dbanty
Copy link
Contributor Author

dbanty commented Jun 26, 2023

No prebuilt ARM just yet: volta-cli/volta#1049

@dbanty dbanty merged commit 95315ba into apollographql:main Jun 26, 2023
@dbanty dbanty deleted the fix-volta-ci-install branch June 26, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants