Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update commit message for automated PRs #252

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

clenfest
Copy link
Contributor

@clenfest clenfest commented Feb 6, 2023

No description provided.

@abernix
Copy link
Member

abernix commented Feb 7, 2023

I've offered this suggestion before but are we sure we don't want to just turn Renovate on for this repository and let it handle the creation of the PRs? Renovate already does all the dependency management stuff and the PR creation work and there is also off the shelf tooling to do Cargo crate publishing that we could probably use.

Plus, we really should to turn it on anyways for dependency management and when we do it's going to open PRs automatically when new versions of @apollo/query-planner, @apollo/composition, @apollo/query-graphs, @apollo/federation-internals are published unless we configure it not to.

Plus, it has the added benefit of automatically adding links to the appropriate changelogs, etc., and I think would tell a more complete story?

@clenfest
Copy link
Contributor Author

clenfest commented Feb 7, 2023

I've offered this suggestion before but are we sure we don't want to just turn Renovate on for this repository and let it handle the creation of the PRs? Renovate already does all the dependency management stuff and the PR creation work and there is also off the shelf tooling to do Cargo crate publishing that we could probably use.

Plus, we really should to turn it on anyways for dependency management and when we do it's going to open PRs automatically when new versions of @apollo/query-planner, @apollo/composition, @apollo/query-graphs, @apollo/federation-internals are published unless we configure it not to.

Plus, it has the added benefit of automatically adding links to the appropriate changelogs, etc., and I think would tell a more complete story?

These were very much a mechanism to automate the manual steps that were in our release process in order to save whoever had to do the release time. I'm very open to other approaches if we think it's worth it to make those changes, but this should be a 1 for 1 with what we were doing before. I didn't think about renovate because of the cargo build steps, but I'm happy with that approach if we prefer it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants