Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring fetchQueryOverInterface within QueryManager #498

Merged
merged 9 commits into from
Aug 3, 2016

Conversation

Poincare
Copy link
Contributor

@Poincare Poincare commented Aug 2, 2016

Working on #471.

TODO:

  • Update CHANGELOG.md with your change
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

// document.
// 4. Returns the final query document and the fragment map associated with the
// query.
private transformQueryDocument(options: WatchQueryOptions): {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there some way we can make this return less stuff? For example, document, definition, and selection set seem a bit redundant.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm still working on the refactor. The final stuff that it will return will probably only be the document and nothing else.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I spoke too soon

@Poincare Poincare changed the title [WIP] Refactoring fetchQueryOverInterface within QueryManager Refactoring fetchQueryOverInterface within QueryManager Aug 2, 2016
@Poincare
Copy link
Contributor Author

Poincare commented Aug 2, 2016

@stubailo what do you think

@stubailo
Copy link
Contributor

stubailo commented Aug 2, 2016

@Poincare do you think it would be valuable to start splitting this into multiple files? or would that just make the code harder to follow?

@Poincare
Copy link
Contributor Author

Poincare commented Aug 2, 2016

I don't think it would make sense to split most of this stuff into multiple files because it ends up using some of the instance variables of QueryManager. The fetchQueryOverInterface logic should stay in QueryManager in my opinion.

@stubailo
Copy link
Contributor

stubailo commented Aug 3, 2016

Looks good to me, let's merge as soon as CI passes

@Poincare Poincare merged commit 1158ff7 into master Aug 3, 2016
@stubailo stubailo deleted the querymanager_refactor branch September 20, 2016 03:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants