-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring fetchQueryOverInterface within QueryManager #498
Conversation
// document. | ||
// 4. Returns the final query document and the fragment map associated with the | ||
// query. | ||
private transformQueryDocument(options: WatchQueryOptions): { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there some way we can make this return less stuff? For example, document, definition, and selection set seem a bit redundant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'm still working on the refactor. The final stuff that it will return will probably only be the document and nothing else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I spoke too soon
@stubailo what do you think |
@Poincare do you think it would be valuable to start splitting this into multiple files? or would that just make the code harder to follow? |
I don't think it would make sense to split most of this stuff into multiple files because it ends up using some of the instance variables of QueryManager. The |
Looks good to me, let's merge as soon as CI passes |
Working on #471.
TODO: