Skip to content

Commit

Permalink
Server: Changed default sandbox mode to chain isolation
Browse files Browse the repository at this point in the history
This might be a better compromise between overhead and stability.
  • Loading branch information
apohl79 committed May 3, 2022
1 parent 52d3a6c commit 8ae6e8c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions Server/Source/Server.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,8 @@ void Server::loadConfig() {
m_crashReporting = jsonGetValue(cfg, "CrashReporting", m_crashReporting);
logln("crash reporting is " << (m_crashReporting ? "enabled" : "disabled"));
m_sandboxMode = (SandboxMode)jsonGetValue(cfg, "SandboxMode", m_sandboxMode);
logln("sandbox mode is " << (m_sandboxMode == SANDBOX_CHAIN ? "chain"
: m_sandboxMode == SANDBOX_PLUGIN ? "plugin"
logln("sandbox mode is " << (m_sandboxMode == SANDBOX_CHAIN ? "chain isolation"
: m_sandboxMode == SANDBOX_PLUGIN ? "plugin isolation"
: "disabled"));
m_sandboxLogAutoclean = jsonGetValue(cfg, "SandboxLogAutoclean", m_sandboxLogAutoclean);
}
Expand Down
2 changes: 1 addition & 1 deletion Server/Source/Server.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ class Server : public Thread, public LogTag {
bool m_vstNoStandardFolders;
bool m_scanForPlugins = true;
bool m_crashReporting = true;
SandboxMode m_sandboxMode = SANDBOX_PLUGIN, m_sandboxModeRuntime = SANDBOX_NONE;
SandboxMode m_sandboxMode = SANDBOX_CHAIN, m_sandboxModeRuntime = SANDBOX_NONE;
bool m_sandboxLogAutoclean = true;

HashMap<String, std::shared_ptr<SandboxMaster>, DefaultHashFunctions, CriticalSection> m_sandboxes;
Expand Down

0 comments on commit 8ae6e8c

Please sign in to comment.