Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow latest rubocop #145

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -147,11 +147,15 @@ Quality uses [semantic versioning](http://semver.org/)--any incompatible changes
(including new tools being added) will come out as major number
updates.

This includes RuboCop upgrades - the quality gem locks in a specific
minor version of RuboCop to avoid your metrics being bumped and
breaking your build.

Expect your build to break on major upgrades if you use RuboCop.
New versions of rubocop, however, will often introduce new rules, which
won't be universally adhered to in your code, which in turn may ratchet your
metrics in the wrong direction! As a result of this we recommend
you lock your Gemfile to a specific minor version of rubocop.

Expect your build to break on major upgrades of this gem,
and minor version upgrades of rubocop. Because this gem requires
rubocop, rubocop will get updated when you update this gem, unless
you have an explicit constraint on rubocop preventing it (AND YOU SHOULD!).

## Supported Ruby Versions

Expand Down
2 changes: 1 addition & 1 deletion coverage/.last_run.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"result": {
"covered_percent": 97.82
"covered_percent": 45.63
}
}
1 change: 1 addition & 0 deletions lib/quality/config.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
# https://github.com/xsc/lein-ancient/issues/29
# https://github.com/xsc/lein-ancient/releases

require 'forwardable'
require_relative 'linguist_source_file_globber'

module Quality
Expand Down
2 changes: 1 addition & 1 deletion quality.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ Gem::Specification.new do |s|
#
# https://github.com/bbatsov/rubocop#installation
s.add_runtime_dependency('mdl')
s.add_runtime_dependency('rubocop', '~> 0.78.0')
s.add_runtime_dependency('rubocop', '>= 0.78')
# 0.2.0 had a fatal bug
s.add_runtime_dependency('bigfiles', ['>= 0.1', '!= 0.2.0'])
s.add_runtime_dependency('brakeman')
Expand Down