Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Tailscale steps order #162

Merged
merged 1 commit into from
Dec 5, 2024
Merged

fix: Tailscale steps order #162

merged 1 commit into from
Dec 5, 2024

Conversation

seyhello
Copy link
Contributor

@seyhello seyhello commented Dec 5, 2024 •
edited
Loading

Fix:

  • Tailscale steps order changed, they must be behind each other as without it, the IAM Assume role step could fail

@seyhello seyhello added the adhoc Ad-hoc unplanned task added during the sprint. label Dec 5, 2024
@seyhello seyhello requested a review from fnesveda December 5, 2024 06:35
@seyhello seyhello self-assigned this Dec 5, 2024
@github-actions github-actions bot added this to the 104th sprint - Platform team milestone Dec 5, 2024
@github-actions github-actions bot added the t-platform Issues with this label are in the ownership of the platform team. label Dec 5, 2024
@seyhello seyhello requested a review from lukasmrtvy December 5, 2024 06:45
fnesveda
fnesveda approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@fnesveda fnesveda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one small note

.github/workflows/deploy_helmfile.yaml
Comment on lines +199 to +203
# Bug https://github.com/tailscale/github-action/issues/107
#- name: Tailscale sleep workaround
# run: |
# sleep 10

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this can be removed now, since we have the next step?

@seyhello seyhello merged commit b3343e1 into main Dec 5, 2024
3 checks passed
@seyhello seyhello deleted the fix/tailscalesteporder branch December 5, 2024 08:05
@github-actions github-actions bot mentioned this pull request Dec 5, 2024
Merged
@fnesveda fnesveda added the validated Issues that are resolved and their solutions fulfill the acceptance criteria. label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fnesveda fnesveda fnesveda approved these changes

@lukasmrtvy lukasmrtvy Awaiting requested review from lukasmrtvy

Assignees

@seyhello seyhello

Labels
adhoc Ad-hoc unplanned task added during the sprint. t-platform Issues with this label are in the ownership of the platform team. validated Issues that are resolved and their solutions fulfill the acceptance criteria.
Projects
None yet
Milestone
104th sprint - Platform team
Development

Successfully merging this pull request may close these issues.
2 participants
@seyhello @fnesveda