Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass the timeout to the resolveProtocol calls #131

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

barjin
Copy link
Contributor

@barjin barjin commented Feb 15, 2024

ALPN negotiation with an unresponsive server caused prolonged hangs, as it didn't respect the specified timeouts.

Fixes #130

@barjin barjin added the bug Something isn't working. label Feb 15, 2024
@barjin barjin self-assigned this Feb 15, 2024
@github-actions github-actions bot added this to the 83rd sprint - Tooling team milestone Feb 15, 2024
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Feb 15, 2024
@barjin barjin requested a review from vladfrangu February 15, 2024 16:43
@barjin barjin merged commit 22661df into master Feb 16, 2024
8 checks passed
@barjin barjin deleted the fix/resolve-protocol-timeout branch February 16, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible to set timeout for ALPN in browser-headers hook
2 participants