Skip to content

Commit

Permalink
chore: pin http2-wrapper version
Browse files Browse the repository at this point in the history
  • Loading branch information
@B4nan
B4nan committed Jul 22, 2021
1 parent 48a8d5e commit e774400
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
2.0.1 / 2021/07/22
====================
- pin `http2-wrapper` version as the latest was causing random CI failures

2.0.0 / 2021/07/22
====================
- **BREAKING**: Require Node.js >=15.10.0 because HTTP2 support on lower Node.js versions is very buggy.
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "got-scraping",
"version": "2.0.0",
"version": "2.0.1",
"description": "HTTP client made for scraping based on got.",
"main": "src/index.js",
"engines": {
Expand Down

5 comments on commit e774400

@szmarczak
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like an issue with Got. [email protected] and [email protected] work the same.

@szmarczak
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately I cannot reproduce the issue here, the test passes with [email protected].

@szmarczak
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that according to the spec headers are case-insensitive.

@szmarczak
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replacing the headers in Got v12 no longer will work: https://github.com/sindresorhus/got/blob/a9afe86ca9cd336371d6416b0073228eb7779e3f/source/core/options.ts#L1695-L1703

@szmarczak
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be best to provide your own (HTTP/1) Agent that will automatically correct the headers appropriately.

Please sign in to comment.