Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add ActorRunPricingInfo type #623

Merged
merged 6 commits into from
Jan 10, 2025
Merged

fix: Add ActorRunPricingInfo type #623

merged 6 commits into from
Jan 10, 2025

Conversation

janbuchar
Copy link
Contributor

No description provided.

@janbuchar janbuchar added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Jan 6, 2025
@janbuchar janbuchar requested a review from B4nan January 6, 2025 17:41
@github-actions github-actions bot added this to the 105th sprint - Tooling team milestone Jan 6, 2025
@janbuchar

This comment was marked as resolved.

Copy link
Contributor

@barjin barjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright to me, I'd maybe capitalize all the JSDocs (and add more details here and there).

src/resource_clients/actor.ts Outdated Show resolved Hide resolved
src/resource_clients/actor.ts Show resolved Hide resolved
Copy link
Contributor

@barjin barjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few more nits

src/resource_clients/actor.ts Show resolved Hide resolved
}

export type FreeActorPricingInfo = CommonActorPricingInfo & {
pricingModel: 'FREE';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a string enum for the pricingModel variants? I've got no hard opinion here though

Copy link
Contributor

@barjin barjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as you are sure about the actual types and response shapes, lgtm 🚀

Copy link
Member

@B4nan B4nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would prefer interfaces over types, simply because of how they are rendered in the API docs

interface has its own page, all properties listed, inheritance is resolved: https://docs.apify.com/api/client/js/reference/interface/Actor
type is just listed on one huge page and you only see the implementation basically: https://docs.apify.com/api/client/js/reference#ActorCollectionListResult

@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Jan 9, 2025
@janbuchar janbuchar requested a review from B4nan January 9, 2025 12:49
@janbuchar
Copy link
Contributor Author

i would prefer interfaces over types, simply because of how they are rendered in the API docs

sure thing, you got it

@janbuchar janbuchar merged commit 8880295 into master Jan 10, 2025
7 checks passed
@janbuchar janbuchar deleted the pricing-info-type branch January 10, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants