-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add ActorRunPricingInfo type #623
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks alright to me, I'd maybe capitalize all the JSDocs (and add more details here and there).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few more nits
} | ||
|
||
export type FreeActorPricingInfo = CommonActorPricingInfo & { | ||
pricingModel: 'FREE'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a string enum for the pricingModel
variants? I've got no hard opinion here though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as you are sure about the actual types and response shapes, lgtm 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would prefer interfaces over types, simply because of how they are rendered in the API docs
interface has its own page, all properties listed, inheritance is resolved: https://docs.apify.com/api/client/js/reference/interface/Actor
type is just listed on one huge page and you only see the implementation basically: https://docs.apify.com/api/client/js/reference#ActorCollectionListResult
sure thing, you got it |
No description provided.