Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(API-1186): Simplify Passport installation in main TestCase #206

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Mohammad-Alavi
Copy link
Member

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (refactoring a current feature, method, etc...)
  • Code Coverage (adding/removing/updating/refactoring tests)
  • New feature (non-breaking change which adds functionality)
  • Remove feature (non-breaking change which removes functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@Mohammad-Alavi Mohammad-Alavi added type: breaking change This change will break existing functionality or compatibility type: refactor Indicates that the issue or PR involves code restructuring without changing its external behavior labels Aug 23, 2024
@Mohammad-Alavi Mohammad-Alavi self-assigned this Aug 23, 2024
@Mohammad-Alavi Mohammad-Alavi changed the title Api 1186 simplify passport installation in main test case [API-1186] Simplify Passport installation in main TestCase Aug 23, 2024
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 7.87%. Comparing base (b328b76) to head (2e3165d).
Report is 3 commits behind head on master.

Files Patch % Lines
src/Abstracts/Tests/PhpUnit/TestCase.php 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             master    #206      +/-   ##
===========================================
+ Coverage      7.78%   7.87%   +0.08%     
+ Complexity      658     651       -7     
===========================================
  Files            99      98       -1     
  Lines          2709    2680      -29     
===========================================
  Hits            211     211              
+ Misses         2498    2469      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mohammad-Alavi Mohammad-Alavi force-pushed the API-1186-Simplify-Passport-installation-in-main-TestCase branch from 0e2ab74 to 2e3165d Compare August 23, 2024 14:38
@Mohammad-Alavi Mohammad-Alavi changed the title [API-1186] Simplify Passport installation in main TestCase Refactor(API-1186): Simplify Passport installation in main TestCase Aug 23, 2024
@Mohammad-Alavi Mohammad-Alavi changed the title Refactor(API-1186): Simplify Passport installation in main TestCase refactor(API-1186): Simplify Passport installation in main TestCase Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: breaking change This change will break existing functionality or compatibility type: refactor Indicates that the issue or PR involves code restructuring without changing its external behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant