Custom container listening scroll events #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 9, 2018 09:03
apertureless
requested changes
Oct 9, 2018
There was a problem hiding this comment.
Please reset the changes to the package.json !
For one, there is no need to add yarn as a dependency.
And never ever change the version of the package. This will be automatically made based on the commits.
Furthermore this is a feature PR so the minor version would change not the patch version, according to semantic versioning.
Otherwise, thanks for the PR! And good work! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Vue-parallax only attaches events to the window element itself which works fine for some cases, but if the user needs a custom container overflowing instead of the default window the
translatemovement does not get applied to the image container.This feature allows a new prop to be passed to the component,
customWrapperReferencewhich is a string reference to an HTML element container (id, class). The scroll event is applied/destroyed to this container instead of the window.Fix or Feature?
Feature
Environment