This closes #9 - error frames should not display any data. Caused by …

…-1 unsigned int overflow
aperepel · Apr 10, 2016 · c63c209 · c63c209
1 parent f1d955d
commit c63c209
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 2 deletions.
diff --git a/source/PJONAnalyzer.cpp b/source/PJONAnalyzer.cpp
@@ -159,7 +159,6 @@ void PJONAnalyzer::WorkerThread()
 //                    mPJON->Advance(samples_per_bit); // TODO advance with tolerance check
 
                     Frame f;
-                    // TODO still display the packet type?
                     f.mFlags = DISPLAY_AS_ERROR_FLAG;
                     f.mStartingSampleInclusive = sync_sample_start;
                     f.mEndingSampleInclusive = mPJON->GetSampleNumber();

diff --git a/source/PJONAnalyzerResults.cpp b/source/PJONAnalyzerResults.cpp
@@ -44,6 +44,7 @@ void PJONAnalyzerResults::GenerateBubbleText( U64 frame_index, Channel& channel,
         case Error: {
             AddResultString("e");
             AddResultString("Error");
+            break;
         }
 
         default: {

diff --git a/source/PJONAnalyzerResults.h b/source/PJONAnalyzerResults.h
@@ -6,7 +6,7 @@
 enum PJONFrameType {
     Sync = 1,
     Data = 2,
-    Error = -1
+    Error = 255
 };
 
 class PJONAnalyzer;