-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding feature to Execute the Inventory Command #134
Adding feature to Execute the Inventory Command #134
Conversation
Thank you very much for your contribution @chungeun-choi I will review it during the next few days! |
@apenella Thank you for your reply! I'll be looking forward to your review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @chungeun-choi !
Thank you very much for your contribution; it will be greatly appreciated by the community!
If you don't mind, before we proceed with merging, I'd like to request some additional work:
- I noticed that ansible-inventory has the '--limit' option, and it might be beneficial to include it here.
- Would you mind adding a description of that package in the readme file, specifically in the packages section?
- Lastly, could I ask you to provide an example showcasing how to use the ansible-inventory feature?
Again thank you very much for your effort and contribution!
@apenella Thanks for the feedback. It seems I missed a few things! I'll leave a comment again after I've made the necessary adjustments |
… 'pattern' parameter
This reverts commit c5ac97e.
@apenella HI!. I've completed all the tasks you requested and am leaving a comment. While checking, I noticed a few issues and made some modifications. Please refer to the content below! Requested Items
ModificationsI apologize for overlooking this feature during development, as it seemed to be a less frequently used one
|
@chungeun-choi you did a great job with that contribution! |
@apenella I'm happy that what I've developed can be helpful! |
Hello go-ansible Contributors!
This is chung-eun, discussing the inventory-related feature (#132). Our project urgently needed this functionality, so I went ahead and developed it.
I'm eager to contribute these developments to the go-ansible project, which is why I've submitted this PR. While I've based my work on the existing contribution guidelines and source code, please don't hesitate to leave comments if there are areas for improvement!☺️
Inventory
ansibleInventoryOptions
: An object to create option flags for executing the ansible-inventory command.ansibleInventoryCmd
: The object that actually executes the ansible-inventory command.inventory_test.go
: A file containing test code to test the newly added features.Special Notes
ConnectionOptions
andPrivilegeEscalationOptions
have been excluded from the properties ofansibleInventoryCmd
.ansibleInventoryOptions
: This functionality has been developed based on the official ansible-inventory documentationI'm not entirely sure which branch this PR should be based on, so I've made the request against the master branch for now. If it needs to be changed, please let me know.