Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: check the API version within the reconcile loop #8616

Merged
merged 5 commits into from
Dec 11, 2024

Conversation

wangyelei
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Dec 10, 2024
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 31.25000% with 33 lines in your changes missing coverage. Please review.

Project coverage is 64.85%. Comparing base (2fc571f) to head (a8a2244).
Report is 3 commits behind head on release-0.9.

Files with missing lines Patch % Lines
pkg/controllerutil/predicate.go 0.00% 15 Missing ⚠️
...g/controller/instanceset/reconciler_api_version.go 66.66% 3 Missing and 1 partial ⚠️
controllers/apps/clusterdefinition_controller.go 25.00% 2 Missing and 1 partial ⚠️
controllers/apps/componentversion_controller.go 25.00% 2 Missing and 1 partial ⚠️
controllers/apps/transformer_cluster_init.go 0.00% 2 Missing and 1 partial ⚠️
controllers/apps/transformer_component_init.go 0.00% 2 Missing and 1 partial ⚠️
controllers/apps/component_controller.go 50.00% 1 Missing ⚠️
controllers/workloads/instanceset_controller.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-0.9    #8616      +/-   ##
===============================================
+ Coverage        64.71%   64.85%   +0.14%     
===============================================
  Files              358      359       +1     
  Lines            45865    45906      +41     
===============================================
+ Hits             29680    29771      +91     
+ Misses           13532    13490      -42     
+ Partials          2653     2645       -8     
Flag Coverage Δ
unittests 64.85% <31.25%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apecloud-bot apecloud-bot added the approved PR Approved Test label Dec 11, 2024
@wangyelei
Copy link
Contributor Author

/approved

@wangyelei wangyelei merged commit 9e26c53 into release-0.9 Dec 11, 2024
39 checks passed
@wangyelei wangyelei deleted the bugfix/filter_v1_event_bug branch December 11, 2024 05:48
@github-actions github-actions bot added this to the Release 0.9.2 milestone Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants