Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use the FQDN of source replica to dump data #8568

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

leon-inf
Copy link
Contributor

@leon-inf leon-inf commented Dec 3, 2024

No description provided.

@leon-inf leon-inf requested a review from a team as a code owner December 3, 2024 07:54
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines. label Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.46%. Comparing base (c206d0e) to head (6c8a3d1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controller/component/replicas.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8568      +/-   ##
==========================================
+ Coverage   60.04%   60.46%   +0.41%     
==========================================
  Files         376      376              
  Lines       45858    45858              
==========================================
+ Hits        27535    27726     +191     
+ Misses      15739    15545     -194     
- Partials     2584     2587       +3     
Flag Coverage Δ
unittests 60.46% <0.00%> (+0.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apecloud-bot apecloud-bot added the approved PR Approved Test label Dec 3, 2024
@leon-inf
Copy link
Contributor Author

leon-inf commented Dec 3, 2024

/approve

@leon-inf leon-inf merged commit a5bcd50 into main Dec 3, 2024
37 checks passed
@leon-inf leon-inf deleted the support/fqdn-of-source-replica branch December 3, 2024 10:53
@leon-inf
Copy link
Contributor Author

leon-inf commented Dec 3, 2024

/cherry-pick release-1.0-beta

@github-actions github-actions bot added this to the Release 0.9.2 milestone Dec 3, 2024
Copy link

github-actions bot commented Dec 3, 2024

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/12138149617

github-actions bot pushed a commit that referenced this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants