chore: support to define and reference the TLS #8538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Nov 27, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8538 +/- ##
==========================================
+ Coverage 60.73% 60.95% +0.21%
==========================================
Files 376 377 +1
Lines 45480 46546 +1066
==========================================
+ Hits 27622 28371 +749
- Misses 15288 15561 +273
- Partials 2570 2614 +44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zjx20
approved these changes
Nov 29, 2024
Y-Rookie
reviewed
Dec 2, 2024
| } | ||
|
|
||
| if common.IsCompactMode(transCtx.Cluster.Annotations) { | ||
| transCtx.V(1).Info("Cluster is in compact mode, no need to create account related objects", "cluster", client.ObjectKeyFromObject(transCtx.Cluster)) |
There was a problem hiding this comment.
fix typo xxx create account xxxx
Y-Rookie
approved these changes
Dec 2, 2024
|
/approve |
apecloud-bot
approved these changes
Dec 2, 2024
|
/cherry-pick release-1.0-beta |
|
🤖 says: cherry pick action finished successfully 🎉! |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 2, 2024
(cherry picked from commit 2d3deb5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.