Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reconcile to preserve the default service type #8506

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

leon-inf
Copy link
Contributor

resolve #8398

@leon-inf leon-inf requested review from Y-Rookie and a team as code owners November 22, 2024 03:34
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.94%. Comparing base (fe24a3a) to head (dfd4451).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controller/component/synthesize_component.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8506      +/-   ##
==========================================
+ Coverage   60.35%   60.94%   +0.59%     
==========================================
  Files         357      357              
  Lines       42555    42796     +241     
==========================================
+ Hits        25684    26084     +400     
+ Misses      14559    14379     -180     
- Partials     2312     2333      +21     
Flag Coverage Δ
unittests 60.94% <80.00%> (+0.59%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@apecloud-bot apecloud-bot added the approved PR Approved Test label Nov 22, 2024
@leon-inf
Copy link
Contributor Author

/approve

@leon-inf leon-inf merged commit 3fa6bc8 into main Nov 22, 2024
37 checks passed
@leon-inf leon-inf deleted the support/default-service-type branch November 22, 2024 09:24
@leon-inf
Copy link
Contributor Author

/cherry-pick release-1.0-beta

@github-actions github-actions bot added this to the Release 0.9.2 milestone Nov 22, 2024
Copy link

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/11969896221

github-actions bot pushed a commit that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
3 participants