Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add grpc handler and proto file #7829

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

Conversation

Ursasi
Copy link
Contributor

@Ursasi Ursasi commented Jul 18, 2024

No description provided.

@github-actions github-actions bot added the size/XXL Denotes a PR that changes 1000+ lines. label Jul 18, 2024
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 86.20690% with 8 lines in your changes missing coverage. Please review.

Project coverage is 64.87%. Comparing base (f5d6853) to head (b0b5f3a).
Report is 12 commits behind head on main.

Files Patch % Lines
pkg/kb_agent/handlers/grpc_handler.go 81.25% 4 Missing and 2 partials ⚠️
pkg/kb_agent/handlers/action.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7829      +/-   ##
==========================================
+ Coverage   64.32%   64.87%   +0.54%     
==========================================
  Files         341      346       +5     
  Lines       42620    42845     +225     
==========================================
+ Hits        27416    27794     +378     
+ Misses      12777    12610     -167     
- Partials     2427     2441      +14     
Flag Coverage Δ
unittests 64.87% <86.20%> (+0.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added size/XL Denotes a PR that changes 500-999 lines. and removed size/XXL Denotes a PR that changes 1000+ lines. labels Jul 18, 2024
xuriwuyun
xuriwuyun previously approved these changes Jul 18, 2024
}

message Request {
string method_name = 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use action as field name?


message Response {
string message = 1;
repeated Parameter parameters = 2;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use metadata?

@apecloud-bot apecloud-bot added the approved PR Approved Test label Jul 18, 2024
@xuriwuyun xuriwuyun dismissed their stale review July 18, 2024 08:57

wrong click

@Ursasi Ursasi marked this pull request as draft August 27, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants