chore: add builder for oteld (#4821) #5807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophon-zt
requested review from
nayutah,
ldming,
heng4fun,
free6om,
wangyelei and
leon-inf
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5807 +/- ##
==========================================
- Coverage 68.42% 68.37% -0.06%
==========================================
Files 286 287 +1
Lines 32802 32848 +46
==========================================
+ Hits 22445 22459 +14
- Misses 8523 8551 +28
- Partials 1834 1838 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ldming
reviewed
Nov 9, 2023
| @@ -56,6 +56,7 @@ func (builder *SecretBuilder) PutData(key string, value []byte) *SecretBuilder { | |||
| data = make(map[string][]byte, 1) | |||
| } | |||
| data[key] = value | |||
| builder.get().Data = data | |||
There was a problem hiding this comment.
https://github.com/apecloud/kubeblocks/pull/5807/files#diff-840970406ceefd84c263207dbcb170c27ad44dff37e9217ab5f1305c0a17971dL39 PutStringData function should builder.get().Data = data
nayutah
approved these changes
Nov 13, 2023
sophon-zt
force-pushed
the
feature/apecloud-monitor-oteld-part-kubeblocks-issue4821
branch
from
1f0ce92 to
874d6af
Compare
|
/approve |
apecloud-bot
approved these changes
Nov 16, 2023
sophon-zt
deleted the
feature/apecloud-monitor-oteld-part-kubeblocks-issue4821
branch
sophon-zt
added a commit
that referenced
this pull request
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.