Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add test for dataprotection #5597

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Conversation

fengluodb
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Oct 24, 2023
@fengluodb fengluodb changed the title Feature/add test for dataprotection feat: add test for dataprotection Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (184cbf1) 69.39% compared to head (a7d0ac1) 70.38%.
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5597      +/-   ##
==========================================
+ Coverage   69.39%   70.38%   +0.99%     
==========================================
  Files         271      271              
  Lines       31157    31115      -42     
==========================================
+ Hits        21621    21901     +280     
+ Misses       7773     7439     -334     
- Partials     1763     1775      +12     
Flag Coverage Δ
unittests 70.38% <81.08%> (+0.99%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
apis/apps/v1alpha1/clusterdefinition_types.go 76.38% <ø> (ø)
...workloads/v1alpha1/replicatedstatemachine_types.go 100.00% <ø> (ø)
...roller/builder/builder_replicated_state_machine.go 93.93% <100.00%> (ø)
pkg/controller/component/lorry_utils.go 91.22% <100.00%> (+0.36%) ⬆️
pkg/controller/rsm/types.go 50.00% <ø> (ø)
controllers/apps/components/component.go 55.35% <93.33%> (+0.54%) ⬆️
controllers/dataprotection/backup_controller.go 75.35% <72.72%> (+5.40%) ⬆️
pkg/controller/factory/builder.go 83.68% <63.15%> (+3.85%) ⬆️
...kg/controller/rsm/transformer_object_generation.go 76.36% <79.59%> (+1.27%) ⬆️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fengluodb fengluodb merged commit 0bc5411 into main Oct 24, 2023
83 checks passed
@fengluodb fengluodb deleted the feature/add-test-for-dataprotection branch October 24, 2023 06:24
@github-actions github-actions bot added this to the Release 0.7.0 milestone Oct 24, 2023
ldming pushed a commit that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature size/L Denotes a PR that changes 100-499 lines. test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] internal/dataprotection/backup code coverage is too low
4 participants