feat: support list cluster service reference #5477
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5477 +/- ##
=======================================
Coverage 68.50% 68.50%
=======================================
Files 269 269
Lines 30858 30858
=======================================
+ Hits 21138 21140 +2
+ Misses 8013 8010 -3
- Partials 1707 1708 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
1aal
requested review from
nayutah,
ldming,
heng4fun,
free6om,
wangyelei and
leon-inf
as code owners
nayutah
approved these changes
Oct 17, 2023
Y-Rookie
approved these changes
Oct 17, 2023
leon-inf
reviewed
Oct 18, 2023
ldming
reviewed
Oct 18, 2023
| } | ||
| for _, serviceDec := range comp.ServiceRefDeclarations { | ||
| for _, ref := range serviceDec.ServiceRefDeclarationSpecs { | ||
| p.AddRow(serviceDec.Name, comp.Name, ref.ServiceKind, ref.ServiceVersion) |
There was a problem hiding this comment.
The first column should be the Name of CD, and add a column to display service ref name. Because this command can list more than one CDs service ref, so need a column to show which CD.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now kbcli support creating cluster with using a service reference with another cluster in KubeBlocks.
So we support
kbcli cluster list-serviceRef [cd-name]to list all serviceRefs declared in a cluster-definition.Example:
