-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support user-defined configmap/secrets (#4885) #5442
Merged
sophon-zt
merged 6 commits into
main
from
support/improvementmount-user-configmaps-issue4885
Nov 3, 2023
Merged
feat: support user-defined configmap/secrets (#4885) #5442
sophon-zt
merged 6 commits into
main
from
support/improvementmount-user-configmaps-issue4885
Nov 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophon-zt
requested review from
free6om,
wangyelei and
leon-inf
as code owners
October 13, 2023 09:30
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5442 +/- ##
==========================================
- Coverage 69.50% 69.46% -0.04%
==========================================
Files 271 271
Lines 31108 31157 +49
==========================================
+ Hits 21622 21644 +22
- Misses 7727 7746 +19
- Partials 1759 1767 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
sophon-zt
force-pushed
the
support/improvementmount-user-configmaps-issue4885
branch
from
October 16, 2023 03:29
077659d
to
aef2704
Compare
sophon-zt
force-pushed
the
support/improvementmount-user-configmaps-issue4885
branch
from
October 23, 2023 06:37
aef2704
to
15186b4
Compare
nayutah
approved these changes
Oct 25, 2023
/approve |
apecloud-bot
approved these changes
Nov 3, 2023
sophon-zt
deleted the
support/improvementmount-user-configmaps-issue4885
branch
November 3, 2023 08:00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
user defines configmap/secrets volumes