Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support user-defined configmap/secrets (#4885) #5442

Merged
merged 6 commits into from
Nov 3, 2023

Conversation

sophon-zt
Copy link
Contributor

user defines configmap/secrets volumes

  componentSpecs:
  - componentDefRef: mysql
    ....
   userResourceRefs:
       secretRefs:
           name: my-secret-volume
           mountPoint: /ops/config
           ### asVolumeFrom defines the list of containers will be injected into volumeMounts.
           asVolumeFrom: 
              - mysql
           secret:
                SecretName:  my-secret
       configMapRefs:
           name: my-config-volume
           mountPoint: /ops/scripts
           ### asVolumeFrom defines the list of containers will be injected into volumeMounts.
           asVolumeFrom: 
              - mysql
           configMap:
                name:  my-config
       

@sophon-zt sophon-zt linked an issue Oct 13, 2023 that may be closed by this pull request
@github-actions github-actions bot added the size/XL Denotes a PR that changes 500-999 lines. label Oct 13, 2023
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (4311028) 69.50% compared to head (15186b4) 69.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5442      +/-   ##
==========================================
- Coverage   69.50%   69.46%   -0.04%     
==========================================
  Files         271      271              
  Lines       31108    31157      +49     
==========================================
+ Hits        21622    21644      +22     
- Misses       7727     7746      +19     
- Partials     1759     1767       +8     
Flag Coverage Δ
unittests 69.46% <89.79%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
apis/apps/v1alpha1/cluster_types.go 81.95% <ø> (ø)
controllers/apps/components/component.go 55.38% <100.00%> (+0.03%) ⬆️
...lers/apps/components/component_workload_builder.go 53.93% <89.58%> (+8.30%) ⬆️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sophon-zt sophon-zt force-pushed the support/improvementmount-user-configmaps-issue4885 branch from 077659d to aef2704 Compare October 16, 2023 03:29
apis/apps/v1alpha1/cluster_types.go Outdated Show resolved Hide resolved
apis/apps/v1alpha1/cluster_types.go Outdated Show resolved Hide resolved
@sophon-zt sophon-zt force-pushed the support/improvementmount-user-configmaps-issue4885 branch from aef2704 to 15186b4 Compare October 23, 2023 06:37
@sophon-zt
Copy link
Contributor Author

/approve

@apecloud-bot apecloud-bot added the approved PR Approved Test label Nov 3, 2023
@sophon-zt sophon-zt added this to the Release 0.8.0 milestone Nov 3, 2023
@sophon-zt sophon-zt merged commit 1d4b137 into main Nov 3, 2023
82 checks passed
@sophon-zt sophon-zt deleted the support/improvementmount-user-configmaps-issue4885 branch November 3, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test feature size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement]Mount User ConfigMaps
4 participants