chore: improved prompt message for configuration reconcile #5323
+13
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophon-zt
requested review from
nayutah,
ldming,
heng4fun,
free6om,
wangyelei and
leon-inf
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5323 +/- ##
==========================================
- Coverage 66.78% 66.76% -0.03%
==========================================
Files 263 263
Lines 29494 29493 -1
==========================================
- Hits 19699 19692 -7
- Misses 8254 8256 +2
- Partials 1541 1545 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
apecloud-bot
approved these changes
Oct 7, 2023
ldming
approved these changes
Oct 8, 2023
sophon-zt
deleted the
support/improved-prompt-message-for-configuration-reconcile
branch
wangyelei
pushed a commit
that referenced
this pull request
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue: #5224 (comment)