Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix regexp bug to enable role snapshot #5318

Closed
wants to merge 1 commit into from

Conversation

derecknowayback
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines. label Oct 7, 2023
@github-actions github-actions bot added this to the Release 0.7.0 milestone Oct 7, 2023
@derecknowayback
Copy link
Contributor Author

/approve

@apecloud-bot apecloud-bot added the approved PR Approved Test label Oct 7, 2023
@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (bc7b193) 66.75% compared to head (99516f9) 66.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5318      +/-   ##
==========================================
- Coverage   66.75%   66.65%   -0.11%     
==========================================
  Files         263      263              
  Lines       29480    29480              
==========================================
- Hits        19679    19649      -30     
- Misses       8260     8281      +21     
- Partials     1541     1550       +9     
Flag Coverage Δ
unittests 66.65% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@derecknowayback derecknowayback deleted the bugfix/lorry-custom-regexp branch October 7, 2023 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test bug enhancement size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants