Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refine configuration reconcile and phase #5311

Merged
merged 2 commits into from
Oct 7, 2023

Conversation

sophon-zt
Copy link
Contributor

No description provided.

@github-actions github-actions bot added this to the Release 0.7.0 milestone Sep 28, 2023
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Sep 28, 2023
@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (4e66a36) 66.76% compared to head (e7679d2) 66.71%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5311      +/-   ##
==========================================
- Coverage   66.76%   66.71%   -0.05%     
==========================================
  Files         263      263              
  Lines       29480    29494      +14     
==========================================
- Hits        19681    19677       -4     
- Misses       8260     8269       +9     
- Partials     1539     1548       +9     
Flag Coverage Δ
unittests 66.71% <82.47%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/controller/configuration/pipeline.go 69.26% <100.00%> (+1.97%) ⬆️
controllers/apps/operations/reconfigure.go 75.30% <50.00%> (+0.81%) ⬆️
...ers/apps/configuration/configuration_controller.go 75.38% <88.46%> (+3.20%) ⬆️
internal/controllerutil/config_util.go 80.26% <81.81%> (+1.19%) ⬆️
controllers/apps/configuration/reconcile_task.go 77.04% <79.41%> (-4.21%) ⬇️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sophon-zt
Copy link
Contributor Author

approve

@sophon-zt
Copy link
Contributor Author

/approve

@apecloud-bot apecloud-bot added the approved PR Approved Test label Oct 7, 2023
@sophon-zt sophon-zt merged commit 1f87a87 into main Oct 7, 2023
@sophon-zt sophon-zt deleted the support/refine-configuration-phase branch October 7, 2023 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test ci size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants