-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix orioledb patroni etcd dependency with Service Reference #5237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1aal
requested review from
nayutah,
ldming,
heng4fun,
free6om,
wangyelei and
leon-inf
as code owners
September 23, 2023 07:11
apecloud-bot
added
dependencies
Pull requests that update a dependency file
enhancement
labels
Sep 23, 2023
1aal
changed the title
fix: fix orioledb etcd dependency with Service Reference
fix: fix orioledb patroni etcd dependency with Service Reference
Sep 23, 2023
nayutah
approved these changes
Sep 25, 2023
Y-Rookie
reviewed
Sep 25, 2023
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5237 +/- ##
==========================================
- Coverage 66.78% 66.77% -0.02%
==========================================
Files 263 263
Lines 29494 29494
==========================================
- Hits 19699 19695 -4
- Misses 8254 8256 +2
- Partials 1541 1543 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Y-Rookie
approved these changes
Oct 2, 2023
ldming
approved these changes
Oct 8, 2023
ldming
pushed a commit
that referenced
this pull request
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
enhancement
size/M
Denotes a PR that changes 30-99 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What i do:
deploy/orioledb/templates/scripts.yaml
cluster register
andcluster create
Usage:
Note:
the default patroni etcd cluster name is "etcd", if you create a etcd cluster named "etcd", you no longer need to specify the cluster's name using --etcd-name.