Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix orioledb patroni etcd dependency with Service Reference #5237

Merged
merged 9 commits into from
Oct 8, 2023

Conversation

1aal
Copy link
Contributor

@1aal 1aal commented Sep 23, 2023

What i do:

  • fix permission denied in GEK by adjusting deploy/orioledb/templates/scripts.yaml
  • no longer mandatory to use a cluster named 'etcd,' but instead, it supports any etcd cluster name created by KubeBlock
  • support for cluster register and cluster create

Usage:

  1. need a etcd cluster first
    image
  2. register the orioledb cluste
    image
  3. create the orioledb cluster and specify the etcd cluster
    image
    image
    image

Note:
the default patroni etcd cluster name is "etcd", if you create a etcd cluster named "etcd", you no longer need to specify the cluster's name using --etcd-name.
image

@apecloud-bot apecloud-bot added dependencies Pull requests that update a dependency file enhancement labels Sep 23, 2023
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label Sep 23, 2023
@1aal 1aal changed the title fix: fix orioledb etcd dependency with Service Reference fix: fix orioledb patroni etcd dependency with Service Reference Sep 23, 2023
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (1f87a87) 66.78% compared to head (2e30bf6) 66.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5237      +/-   ##
==========================================
- Coverage   66.78%   66.77%   -0.02%     
==========================================
  Files         263      263              
  Lines       29494    29494              
==========================================
- Hits        19699    19695       -4     
- Misses       8254     8256       +2     
- Partials     1541     1543       +2     
Flag Coverage Δ
unittests 66.77% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@1aal 1aal requested a review from Y-Rookie September 27, 2023 07:36
@JashBook JashBook added this to the Release 0.7.0 milestone Sep 27, 2023
@1aal 1aal merged commit 4fdd873 into main Oct 8, 2023
55 of 58 checks passed
@1aal 1aal deleted the bugfix/fix-orioledb-dependency branch October 8, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
6 participants