Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add applications subdir #2

Merged
merged 5 commits into from
Sep 25, 2023
Merged

feat: add applications subdir #2

merged 5 commits into from
Sep 25, 2023

Conversation

ldming
Copy link
Collaborator

@ldming ldming commented Sep 23, 2023 •
edited
Loading

  • Add all addon CRs in KubeBlocks helm chart
  • Add applications sub directory
  • Rename plugins to cli-plugins

@ldming ldming changed the title feat: add tools and applications subdir feat: split addons to tools and applications subdir Sep 23, 2023
@fengluodb
Copy link
Contributor

fengluodb commented Sep 23, 2023 •
edited
Loading

If rename plugins to cli-plugins, the kbcli plugin cmd needs adaptation. The plugin cmd will also need to search cli-plugins dir. We need a issue to mark it when this pr is merged.

@ldming ldming changed the title feat: split addons to tools and applications subdir feat: add applications subdir Sep 25, 2023
@ldming ldming merged commit a58d22e into main Sep 25, 2023
1 check failed
@ldming ldming deleted the feature/support-more-subdir branch September 25, 2023 07:41
@fengluodb fengluodb mentioned this pull request Sep 28, 2023
Closed
@ldming ldming mentioned this pull request Oct 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1aal 1aal 1aal approved these changes

@fengluodb fengluodb fengluodb approved these changes

@nayutah nayutah Awaiting requested review from nayutah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ldming @fengluodb @1aal