[YUNIKORN-2153]Optimize Placement of predicateCheckResult for Better Maintainability #1011
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Create predicate.go to encapsulate the declaration and implementation of
predicateCheckResult
, improves code organization by centralizing predicate-related logic, enhancing maintainability and readability.What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/projects/YUNIKORN/issues/YUNIKORN-2153
How should this be tested?
2.1 Create cluster with kind and install yunikorn
2.2 Create pods with low priority but request a lot of resources
2.3 Create a pod with higher priority
2.4 Some of pods created at 2.2 are eviction and pod in 2.3 can be scheduled to k8s cluster
Screenshots (if appropriate)
Questions: