Open NoOpBarrierStep for extensibility #2612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.7-dev #2612 +/- ##
=============================================
+ Coverage 76.14% 76.78% +0.63%
- Complexity 13152 13189 +37
=============================================
Files 1084 1087 +3
Lines 65160 66304 +1144
Branches 7285 7293 +8
=============================================
+ Hits 49616 50911 +1295
+ Misses 12839 12680 -159
- Partials 2705 2713 +8 ☔ View full report in Codecov by Sentry. |
9 tasks
ntisseyre
approved these changes
May 19, 2024
|
VOTE +1 |
Signed-off-by: Oleksandr Porunov <[email protected]>
porunov
force-pushed
the
feature/refactor-no-op-barrier-step
branch
from
5f2aff6 to
1f9ce19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it possible to extend and overwrite
NoOpBarrierStep.Reason for this change: JanusGraph/janusgraph#4456 (comment)
Related discussion (Discord thread about
barrier+dropstep usage): https://discord.com/channels/838910279550238720/1241219665376706603Related discussion where the conclusion was made to relax individual steps based on necessity: https://lists.apache.org/thread/vjbjh29kwjhd5lcmkqqqqrhw7rw2ynh9