Upgrade Underscore.js to version 1.13.6 #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We ran into the same issue after a recent pen test and updated it internally; there have been no issues so far. Initially, I thought about removing underscore.js altogether, as only a few methods appeared to be used. For easier release management, I will create a Jira ticket this weekend to track the changes before merging the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tapestry uses Underscore.js version 1.8.3, which is more than eight years old (April 2015) and includes some security vulnerabilities. I would like to upgrade it to the latest version, which is currently 1.13.6, to fix the security issues.
It would be great to include this change in the next bug fix version of Tapestry, 5.8.4.